Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime-linker-tests: revert earlier change which added browser offse… #49774

Merged
merged 3 commits into from
Mar 18, 2021
Merged

runtime-linker-tests: revert earlier change which added browser offse… #49774

merged 3 commits into from
Mar 18, 2021

Conversation

radical
Copy link
Member

@radical radical commented Mar 17, 2021

…ts as a dep

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@radical
Copy link
Member Author

radical commented Mar 17, 2021

The first commit reverts the change that broke dotnet-linker-tests. CI should now fail other builds because of that. I will have to wait for that, and then figure out a fix.

@radical radical mentioned this pull request Mar 17, 2021
Merged
@radical radical mentioned this pull request Mar 18, 2021
Closed
lewing
lewing approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to wait for this to build right?

@radical
Copy link
Member Author

radical commented Mar 18, 2021

We don't need to wait for this to build right?

I want to wait till at least the browser build for dotnet-linker-tests finishes, so we know for sure that the /p:WasmNativeBuild=false fix works fine, and doesn't throw up anything else.

@radical radical merged commit eceb5c8 into dotnet:main Mar 18, 2021
@radical radical deleted the fix-ci branch March 18, 2021 03:25
@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@radical @lewing @karelz